Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Always use OTEL as metric handler (#7265)" #7303

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

yycptt
Copy link
Member

@yycptt yycptt commented Feb 10, 2025

This reverts commit c156e84.

What changed?

Why?

  • StatsD still needs tally to function
  • OTEL metric handler doesn't support Prefix and the same customized/default sanitization logic as tally

@yycptt yycptt requested a review from yiminc February 10, 2025 19:38
@yycptt yycptt requested a review from a team as a code owner February 10, 2025 19:38
@yycptt yycptt merged commit 14e488b into temporalio:main Feb 11, 2025
49 checks passed
@yycptt yycptt deleted the revert-otel branch February 11, 2025 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants