Skip to content
This repository has been archived by the owner on May 29, 2023. It is now read-only.

NerdTabs added #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

darkcoderrises
Copy link

I added NerdTree tabs to be closed while making the session and saving it. Please add it as it is a useful feature.

@sarahkittyy
Copy link

This pull is broken. When NERDTree closes and reopens after every save (this includes simply trying to switch between splits!) vim focuses the cursor back on the NERDTree window, causing a loop where you can't focus any other split except NERDTree.

@sarahkittyy
Copy link

(Also it has enormous stuttering in general on each save)

@darkcoderrises
Copy link
Author

Yeah, it goes in a loop. I can try to fix those issues if you are willing to merge?

Copy link
Owner

@thaerkh thaerkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @darkcoderrises thank you for your contribution (and apologies for the late response) - yes I'd be willing to merge this if fixed, and have one small request on checking if the Nerdtree plugin exists

@@ -50,13 +50,18 @@ endfunction
function! s:MakeWorkspace(workspace_save_session)
if a:workspace_save_session == 1 || get(s:, 'workspace_save_session', 0) == 1
let s:workspace_save_session = 1
let l:nerd_tree = g:NERDTree.IsOpen()
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a check in cases like here where the plugin doesn't exist for a given user?

@thaerkh thaerkh force-pushed the master branch 5 times, most recently from 199504c to a9ae9ce Compare May 10, 2023 12:40
@thaerkh thaerkh force-pushed the master branch 4 times, most recently from c3275db to c0d1e43 Compare May 29, 2023 04:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants