-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bakta] update to latest version full and light db #740
Open
fraser-combe
wants to merge
22
commits into
main
Choose a base branch
from
fc-bakta-update-dev
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+103
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Good suggestion I've updated the workflow and documentation so user inputs string "light" , "full" or the gsurl to the custom bucket Re ran theiaprok workflows to confirm custom light and full strings are working as expected Theiaprok ont confirmed other theiaprok workflows are successful for bakta theiaprok illumina PE and SE (default settings) theiaprok_fasta (default settings) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #445
🗑️ This dev branch should be deleted after merging to main.
🧠 Summary
This PR updates Bakta to the latest version 1.10.3, incorporating both the full and light databases
⚡ Impacted Workflows/Tasks
Tasks: task_bakta.wdl
Workflows TheiaProk workflows have been updated to incorporate the full and light database download before the call and updated outputs
This PR may lead to different results in pre-existing outputs: No
This PR uses an element that could cause duplicate runs to have different results: No
🛠️ Changes
⚙️ Algorithm
➡️ Inputs
Added bakta_db input to specify database type (light, full, or custom).
bakta_custom_db input for user-defined database paths.
⬅️ Outputs
Outputs now include a summary plot (.png)
![image](https://private-user-images.githubusercontent.com/66448022/406586441-10910329-091e-4f01-8cb6-ec9f8681b3dd.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5MTMzOTQsIm5iZiI6MTczODkxMzA5NCwicGF0aCI6Ii82NjQ0ODAyMi80MDY1ODY0NDEtMTA5MTAzMjktMDkxZS00ZjAxLThjYjYtZWM5Zjg2ODFiM2RkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA3VDA3MjQ1NFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTEwZTIzMzEyMWQ1NGM4NjgxNzg5YTA0YzNmZjZhNmJjMmRjYzI2YmRkMjVkYWZiZTFkNmM5MGViODcxNmNlODYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.7ecAiWwfnWWy2IjkwSUq3YloAc6fGC2dQim_iQSMFXU)
🧪 Testing
Verified Bakta annotation with the full and light databases.
Confirmed database extraction and annotation processes.
Ran all Theiaprok workflows to confirm successful Bakta annotation and outputs file generation
Theiaprok_FASTA - light db
TheiaProk_Illumina_SE - light db
TheiaProk_Illumina_PE - light db
TheiaProk_Illumina_ONT - Light db
TheiaProk Illumina_ONT - Full db
Suggested Scenarios for Reviewer to Test
Test annotations with the light and full database
Confirm output files are generated correctly, including summary plots.
Opinions on the runtime parameters will be useful. I had to increase disk size to deal with the full database.
🔬 Final Developer Checklist
workflows_overview
tables to be the tag for the next upcoming release. If you do not know the tag, please put "vX.X.X"🎯 Reviewer Checklist