Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llext: use the new inspection API #9823

Closed
wants to merge 4 commits into from

Conversation

pillo79
Copy link

@pillo79 pillo79 commented Feb 10, 2025

This PR tries to improve SOF by minimizing its dependency on LLEXT internals.
Instead of relying on direct field access, the code in llext_manager.c is refactored to use a set of new, stable LLEXT APIs that expose the same information. These code changes should have no measurable effects in the rest of SOF.

Note

@sofci
Copy link
Collaborator

sofci commented Feb 10, 2025

Can one of the admins verify this patch?

reply test this please to run this test once

Copy link
Member

@lgirdwood lgirdwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @lyakh pls review

@lgirdwood
Copy link
Member

test this please

@pillo79 pillo79 force-pushed the pr-llext-inspect-api branch 2 times, most recently from a579f71 to e36aac2 Compare February 11, 2025 09:04
Copy link
Contributor

@jsarha jsarha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of issues i found while trying to understand what this (and the llext code in general) does (which is still on going).

src/library_manager/llext_manager.c Outdated Show resolved Hide resolved
src/library_manager/llext_manager.c Show resolved Hide resolved
@pillo79 pillo79 force-pushed the pr-llext-inspect-api branch from e36aac2 to e99d9d5 Compare February 11, 2025 09:37
@lyakh
Copy link
Collaborator

lyakh commented Feb 11, 2025

SOFCI TEST

@pillo79 pillo79 force-pushed the pr-llext-inspect-api branch from e99d9d5 to a75cf84 Compare February 11, 2025 14:58
This is a temporary change to use the Zephyr PR adding the new LLEXT
inspection API. This is needed to test the SOF integration with the new
API.

Signed-off-by: Luca Burelli <[email protected]>
This commit does some minor preparatory refactors in the llext_manager
module in preparation for the upcoming change to use the new LLEXT
inspection API.

Signed-off-by: Luca Burelli <[email protected]>
@pillo79 pillo79 force-pushed the pr-llext-inspect-api branch from 1c0910c to 0ab0537 Compare February 11, 2025 16:48
This patch converts the llext_manager to use the new LLEXT inspection
API. The new API allows to get information about sections and regions
without the need to access the internal structures of the LLEXT loader,
decoupling SOF and LLEXT code and making it easier to maintain.

Signed-off-by: Luca Burelli <[email protected]>
@pillo79 pillo79 force-pushed the pr-llext-inspect-api branch from 0ab0537 to 99611bc Compare February 12, 2025 08:03
@lyakh
Copy link
Collaborator

lyakh commented Feb 12, 2025

SOFCI TEST

@lgirdwood
Copy link
Member

@pillo79 I've added you to sof-developers so new PRs will automatically run in CI.

Add debugging code for comparing memory copy operations between previous
and current situations.

Signed-off-by: Luca Burelli <[email protected]>
@pillo79 pillo79 force-pushed the pr-llext-inspect-api branch from 99611bc to 4987f62 Compare February 12, 2025 13:10
@lyakh
Copy link
Collaborator

lyakh commented Feb 12, 2025

SOFCI TEST

@pillo79
Copy link
Author

pillo79 commented Feb 13, 2025

Closed in favor of #9831 to take advantage of the new SOF developer status and run CI automatically (thanks so much! 😍).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants