llext: use the new inspection API (continued) #9831
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pillo79
changed the title
pillo79
force-pushed
the
pr-llext-inspect-api
branch
from
2606529 to
4c8d65c
Compare
pillo79
force-pushed
the
pr-llext-inspect-api
branch
2 times, most recently
from
54691e3 to
21dcc83
Compare
llext_manager_load_module() and llext_manager_link() are only interested in the llext_loader part of the llext_buf_loader structure. This patch refactors the code to pass the llext_loader directly, making the code more readable. No functional change is intended. Signed-off-by: Luca Burelli <[email protected]>
For inspection API to work, it is imperative to keep the LLEXT loader object available. This patch adds the llext_buf_loader to module_data structure and allocates it the first time the module is loaded. Signed-off-by: Luca Burelli <[email protected]>
The function llext_unload was modifying a stack variable and not the actual private member holding the reference. This could have lead to a double free or invalid access to a freed llext structure. Signed-off-by: Luca Burelli <[email protected]>
This updates the Zephyr revision to include the LLEXT inspection API. Signed-off-by: Luca Burelli <[email protected]>
This patch converts the llext_manager to use the new LLEXT inspection API. The new API allows to get information about sections and regions without the need to access the internal structures of the LLEXT loader, decoupling SOF and LLEXT code and making it easier to maintain. Signed-off-by: Luca Burelli <[email protected]>
Add debugging code for comparing memory copy operations between previous and current situations. Signed-off-by: Luca Burelli <[email protected]>
pillo79
force-pushed
the
pr-llext-inspect-api
branch
from
21dcc83 to
e625dcb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a newly added SOF developer, had to close #9823 and open a new PR to take advantage of automatic CI runs (and therefore stop nagging @lyakh all day! 😁)
Still WIP as I try to figure out the issues identified in CI.
This PR tries to improve SOF by minimizing its dependency on LLEXT internals.
Instead of relying on direct field access, the code in
llext_manager.cis refactored to use a set of new, stable LLEXT APIs that expose the same information. These code changes should have no measurable effects in the rest of SOF.Note
Requires yet-to-be-upstreamed llext: add new inspection API zephyrproject-rtos/zephyr#85498, so "Zephyr / build-linux" failures onEDIT: Zephyr PR merged.mainare expected