Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add load and loadAsync methods back to Loader #570

Merged
merged 4 commits into from
Jul 31, 2023
Merged

Conversation

Methuselah96
Copy link
Contributor

Why

When writing code that should work with any loader, it's useful to have the load and loadAsync methods available on the Loader class. Since loadAsync is actually implemented in Loader, introducing generics, allows us to make sure the data types align.

What

Add TData and TUrl generics to Loader in order to redefined the load and loadAysnc methods in Loader.

Checklist

  • Checked the target branch (current goes master, next goes dev)
  • Added myself to contributors table
  • Ready to be merged

@Methuselah96 Methuselah96 merged commit f8e5198 into master Jul 31, 2023
3 checks passed
@Methuselah96 Methuselah96 deleted the loader-load branch July 31, 2023 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant