Fix cell-change crash from SetActorInventory() calling s_unequipAll followed by s_removeAllItems #726
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cter that the remote system is obviously not authoratative for. From the code comment: Only accept spawn position and inventory updates if not for local player The remote system is simply not authoritative for this info, and trying to take it from the remote can result in concurrent update corruption That's the real problem, either s_pRemoveAllItems or s_unequipAll have async behavior themselves or undocumented behavior that causes concurrency issues.
…ta looping back to themselves.
rfortier
changed the title
Open
3 tasks
|
Reverted the 2nd fix for now, as is riskier and may be supplanted by a more comprehensive fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a cell change crash provoked by bugs in Actor::SetActorInventory(), but really a bug in the downcall to EquipManager::UnequipAll() which invokes skyrim-native TUnequipAll.
SetActorInventory() effectively calls UnequipAll(), RemoveAllItems(), then sets the new inventory with AddRemoveItem(). But the RemoveAllItems() script also Unequips() each item, which seems to trigger a bug because the UnequipAll is still animating unequips.
First fix is comment out the unequipall.
Second fix is remove as many SetActorInventory() calls as possible. In particular, when you set the inventory on a local Actor, you don't also have to set it again when the change reflects back to you in OnRemoteSpawnDataReceived(). That's just a more elaborate way of provoking overlapping Unequips (basically, back-to-back RemoveAllItems())
Partially addresses #723 (0x140443C43 crash site)