Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cell-change crash from SetActorInventory() calling s_unequipAll followed by s_removeAllItems #726

Merged
merged 5 commits into from
Oct 26, 2024

Commits on Oct 23, 2024

  1. Configuration menu
    Copy the full SHA
    b63023b View commit details
    Browse the repository at this point in the history
  2. Don't accept OnRemoteSpawnDataReceived data for the local PlayerChara…

    …cter that the remote system is obviously not authoratative for.
    
    From the code comment:
    Only accept spawn position and inventory updates if not for local player
    The remote system is simply not authoritative for this info, and trying
    to take it from the remote can result in concurrent update corruption
    That's the real problem, either s_pRemoveAllItems or s_unequipAll
    have async behavior themselves or undocumented behavior that
    causes concurrency issues.
    rfortier committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    49bfc73 View commit details
    Browse the repository at this point in the history
  3. Loosen the check ALL local NPCs should reject updated remote spawn da…

    …ta looping back to themselves.
    rfortier committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    ed79bf1 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2024

  1. Revert "Loosen the check ALL local NPCs should reject updated remote …

    …spawn data looping back to themselves."
    
    This reverts commit ed79bf1.
    rfortier committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    90946c7 View commit details
    Browse the repository at this point in the history
  2. Revert "Don't accept OnRemoteSpawnDataReceived data for the local Pla…

    …yerCharacter that the remote system is obviously not authoratative for."
    
    This reverts commit 49bfc73.
    rfortier committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    c53d7c8 View commit details
    Browse the repository at this point in the history