-
Notifications
You must be signed in to change notification settings - Fork 6
Add term table, accomodate multiple terms, fix course.sis_id bug (#113, #117) #115
Add term table, accomodate multiple terms, fix course.sis_id bug (#113, #117) #115
Conversation
@ssciolla, any idea why Codacy claims Can we use comments to tell Codacy (or in this case, PyLint specifically) to ignore this error for this section of code? (https://github.com/tl-its-umich-edu/course-inventory/pull/115/files#diff-9e1a06acd700cfb38555dc5980f1cdb0R163) |
I think that's an issue that was there before; it doesn't like the default mutable argument of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After discussion, the things I commented on seem to be minor issues, so I'll give my approval of this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this seems fine and will work. The only problem is that there is no indication of the term for the canvas_zoom_meetings in the csv report but I don't think this is necessary right now and this will be changed anyway with #114. Just have the one fix that should probably be made.
This PR modifies the
COURSE_INVENTORY
job and the database schema as to be able to collect and store data related to multiple academic terms. Some additional details are provided in the task list below. This PR aims to resolve issues #113 and #117.term
table and with aterm_id
column and foreign key constraint to thecourse
table.CANVAS_TERM_ID
configuration variable plural, i.e.CANVAS_TERM_IDS
.get_course_data_from_api
function to accept multiple terms, nest fetching process insidefor
loop, and then combine all results into onecourse_df
(ensuring that future processes will consider courses from the multiple terms specified).term_df
to database.course.sis_id
toVARCHAR(15)
and type coercion to string of those values (see issue Change data type of course.sis_id to VARCHAR #117 for details).online_meetings/canvas_zoom_meetings.py
to handle multiple terms.