Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store player state as room metadata #615

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

joaobologna
Copy link
Collaborator

@joaobologna joaobologna commented May 2, 2024

The player state in a game room is not managed by Maestro. This is an experimental MR to store the player count in the room metadata, that way Maestro will be the owner of connected players in a room.

@joaobologna joaobologna marked this pull request as draft May 2, 2024 13:24
@hspedro hspedro force-pushed the feature/store-player-state branch from 45b592c to 26d5646 Compare May 2, 2024 14:07
@codecov-commenter
Copy link

codecov-commenter commented May 2, 2024

Codecov Report

Attention: Patch coverage is 76.19048% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 81.49%. Comparing base (b3fc9e1) to head (8a5db9a).
Report is 2 commits behind head on main.

Files Patch % Lines
...l/core/services/events/events_forwarder_service.go 76.19% 3 Missing and 2 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #615      +/-   ##
==========================================
- Coverage   81.51%   81.49%   -0.02%     
==========================================
  Files          85       85              
  Lines        5789     5810      +21     
==========================================
+ Hits         4719     4735      +16     
- Misses        877      880       +3     
- Partials      193      195       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants