Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor docker image #623

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

oneonestar
Copy link
Member

Description

Fix #598
Some refactoring:

  • /opt/trino -> /opt/trino-gateway
  • /usr/lib/trino -> /usr/lib/trino-gateway
  • /opt/trino/gateway-ha-config.yml -> /opt/trino-gateway/config.yaml

Need to follow up with an update in chart.

Release notes

(x) Release notes are required, with the following suggested text:

* [:warning: Breaking change:](#breaking) Change configuration file name in Docker image from 
  `/opt/trino/gateway-ha-config.yml` to `/opt/trino-gateway/config.yaml`.

@cla-bot cla-bot bot added the cla-signed label Feb 19, 2025
Copy link
Member

@Chaho12 Chaho12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@oneonestar oneonestar force-pushed the star/refactor_docker_structure branch from 3358bae to 06d69d8 Compare February 19, 2025 23:19
@oneonestar oneonestar requested a review from mosabua February 19, 2025 23:20
Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. We should update the commit message to something like

`Improve path and file names in Docker image"

before merging ..

@oneonestar oneonestar force-pushed the star/refactor_docker_structure branch from 06d69d8 to 00d68b1 Compare February 19, 2025 23:42
@oneonestar oneonestar merged commit e0493ae into trinodb:main Feb 20, 2025
2 checks passed
@oneonestar oneonestar deleted the star/refactor_docker_structure branch February 20, 2025 00:41
@github-actions github-actions bot added this to the 15 milestone Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Simplify configuration file name
3 participants