Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NullIf.java #24911

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update NullIf.java #24911

wants to merge 1 commit into from

Conversation

0xDS
Copy link

@0xDS 0xDS commented Feb 5, 2025

verify that first and second can be coerced to the same type

Description

Additional context and related issues

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

## Section
* Fix some things. ({issue}`issuenumber`)

verify that first and second can be coerced to the same type
Copy link

cla-bot bot commented Feb 5, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@@ -33,7 +33,9 @@ public record NullIf(Expression first, Expression second)
requireNonNull(first, "first is null");
requireNonNull(second, "second is null");

// TODO: verify that first and second can be coerced to the same type
if (!first.type().equals(second.type())) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

being the same type is NOT the same as being able to coerce to the same type ..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants