Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NullIf.java #24911

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update NullIf.java #24911

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion core/trino-main/src/main/java/io/trino/sql/ir/NullIf.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,9 @@ public record NullIf(Expression first, Expression second)
requireNonNull(first, "first is null");
requireNonNull(second, "second is null");

// TODO: verify that first and second can be coerced to the same type
if (!first.type().equals(second.type())) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

being the same type is NOT the same as being able to coerce to the same type ..

throw new IllegalArgumentException("first and second must be of the same type");
}
}

@Override
Expand Down
Loading