deploy: add initial vllm worker chart #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR makes me realize that we need to agree on a mechanism for Helm chart validation / testing. If we can agree to allowing the test to be run using |
whoisj
force-pushed
the
jwyman/helm-chart-1
branch
from
fa264bd to
d497e15
Compare
whoisj
force-pushed
the
jwyman/helm-chart-1
branch
from
d497e15 to
d897370
Compare
whoisj
force-pushed
the
jwyman/helm-chart-1
branch
from
d897370 to
1050df6
Compare
whoisj
force-pushed
the
jwyman/helm-chart-1
branch
from
1050df6 to
2daf46e
Compare
whoisj
force-pushed
the
jwyman/helm-chart-1
branch
from
2daf46e to
7ab11ef
Compare
whoisj
force-pushed
the
jwyman/helm-chart-1
branch
from
7ab11ef to
cbdbe86
Compare
whoisj
force-pushed
the
jwyman/helm-chart-1
branch
from
cbdbe86 to
ed22f12
Compare
whoisj
force-pushed
the
jwyman/helm-chart-1
branch
from
ef3d8fb to
b334cac
Compare
whoisj
force-pushed
the
jwyman/helm-chart-1
branch
from
b334cac to
862151c
Compare
|
@alec-flowers I've updated the documentation inside |
whoisj
force-pushed
the
jwyman/helm-chart-1
branch
from
862151c to
470fb60
Compare
whoisj
force-pushed
the
jwyman/helm-chart-1
branch
from
470fb60 to
71ba488
Compare
whoisj
force-pushed
the
jwyman/helm-chart-1
branch
from
71ba488 to
a2b613c
Compare
whoisj
force-pushed
the
jwyman/helm-chart-1
branch
from
a2b613c to
f5fed62
Compare
| {{- end }} | ||
| {{- if false }} | ||
| # What are these and are they needed? HELP! | ||
| - VLLM_ATTENTION_BACKEND: 0 |
There was a problem hiding this comment.
We have similar variables here. The VLLM prefix part is used to configure vLLM engine, NATS are of request plane.
There was a problem hiding this comment.
yes I see that. What should the value be by default and what are the allowed values?
whoisj
force-pushed
the
jwyman/helm-chart-1
branch
from
f5fed62 to
207db46
Compare
This change adds the initial version of the vLLM worker Helm chart. This is NOT the final values schema. Includes schema validation and embedded chart scripting to enable default values.
whoisj
force-pushed
the
jwyman/helm-chart-1
branch
from
207db46 to
c1803dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the initial version of the vLLM worker Helm chart.
This is NOT the final values schema.
Includes schema validation and embedded chart scripting to enable default values.
No tests included because we have not yet agreed on the best mechanism to validate Helm charts.
DLIS-7810