-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Report histogram metrics to Triton metrics server #58
Merged
yinggeh
merged 36 commits into
main
from
yinggeh-DLIS-7113-support-histogram-metric-type
Aug 16, 2024
Merged
feat: Report histogram metrics to Triton metrics server #58
yinggeh
merged 36 commits into
main
from
yinggeh-DLIS-7113-support-histogram-metric-type
Aug 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d into yinggeh-DLIS-7061-add-vllm-metrics
…TRICS" in config.pbtxt.
Merged #56 to the wrong branch. Needs approval for this PR. My apologies. |
rmccorm4
approved these changes
Aug 16, 2024
mc-nv
pushed a commit
that referenced
this pull request
Aug 19, 2024
mc-nv
added a commit
that referenced
this pull request
Aug 19, 2024
Co-authored-by: Yingge He <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sample histogram output
What does the PR do?
Support histogram metric type and add tests.
Checklist
<commit_type>: <Title>
Commit Type:
Check the conventional commit type
box here and add the label to the github PR.
Related PRs:
triton-inference-server/python_backend#374
triton-inference-server/core#386
triton-inference-server/server#7525
Where should the reviewer start?
n/a
Test plan:
n/a
17487728
Caveats:
n/a
Background
Customer requested histogram metrics from vLLM.
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
n/a