Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

socialhub-fa:1.0.0 #218

Merged
merged 6 commits into from
Dec 3, 2023
Merged

socialhub-fa:1.0.0 #218

merged 6 commits into from
Dec 3, 2023

Conversation

Bi0T1N
Copy link
Contributor

@Bi0T1N Bi0T1N commented Nov 4, 2023

I am submitting

  • a new package
  • an update for a package

Description:
The socialhub-fa package is designed to help you create your curriculum vitae (CV). It allows you to easily reference your social media profiles with the typical icon of the service plus a link to your profile.

I have read and followed the submission guidelines and, in particular, I

  • selected a name in conformance with the guidelines
  • added a typst.toml file with all required keys
  • added a README.md with documentation for my package
  • have chosen a license and added a LICENSE file or linked one in my README.md
  • ensured that my submission does not infringe upon the rights of a third party
  • tested my package locally on my system and it worked
  • named this PR as name:version of the submitted package
  • agree that my package will not be removed without good reason

@laurmaedje laurmaedje added the new A new package submission. label Nov 6, 2023
@reknih
Copy link
Member

reknih commented Nov 7, 2023

Thank you for your package submission! We have to ask you to change the name of this package since social could be the natural name for packages with this functionality. By taking up this name, the potential for other packages to improve upon this one is reduced. We can continue merging this once you push a new name!

@reknih reknih added the blocked This PR is blocked by something. label Nov 7, 2023
@Bi0T1N
Copy link
Contributor Author

Bi0T1N commented Nov 11, 2023

Thank you for your package submission! We have to ask you to change the name of this package since social could be the natural name for packages with this functionality. By taking up this name, the potential for other packages to improve upon this one is reduced. We can continue merging this once you push a new name!

Would social-fa (fa for Font Awesome) be accepted as package name? Or is it preferred to have long versions for package names: social-font-awesome?

@reknih
Copy link
Member

reknih commented Nov 13, 2023

Both names would be acceptable. Meanwhile, have you considered something less normative along the lines of socialite or influencer?

@Bi0T1N
Copy link
Contributor Author

Bi0T1N commented Nov 16, 2023

Both names would be acceptable. Meanwhile, have you considered something less normative along the lines of socialite or influencer?

I don't have a firm opinion on the name. I've simply taken what I'm used to from LaTeX.
Some other ideas:

  • socialhub
  • references (probably too generic)
  • socialreferences
  • internetreferences
  • websiterefs

I'm open to all kinds of suggestions. 😄

@reknih
Copy link
Member

reknih commented Nov 18, 2023

Socialhub would work!

Bi0T1N added a commit to Bi0T1N/typst-iconic-salmon-fa that referenced this pull request Nov 30, 2023
@Bi0T1N Bi0T1N changed the title social:1.0.0 socialhub-fa:1.0.0 Nov 30, 2023
@Bi0T1N
Copy link
Contributor Author

Bi0T1N commented Nov 30, 2023

I've renamed to package to socialhub-fa (fa is the short version of font awesome)

@laurmaedje laurmaedje removed the blocked This PR is blocked by something. label Nov 30, 2023
@laurmaedje laurmaedje merged commit 1d1a3cc into typst:main Dec 3, 2023
1 check passed
@laurmaedje
Copy link
Member

Thanks!

@Bi0T1N Bi0T1N deleted the social branch March 23, 2024 19:22
@Bi0T1N Bi0T1N mentioned this pull request Mar 29, 2024
9 tasks
@Bi0T1N Bi0T1N mentioned this pull request Apr 20, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new A new package submission.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants