-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Photo pipeline #42
Photo pipeline #42
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks really good, only issue I'm having is with uploading a new profile picture on the volunteer profile page. Uploaded picture doesn't show on the ui and doesn't get inserted into the db
There was an issue with checking mime types, its been resolved now. Additionally noticed some issues with creating accounts so updated the volunteerModel.createVolunteer method |
Ya everything looks good to me now, nice work man |
Great work Theo Super clean optimization to have images in one table. As a sanity check I've dropped the original class_image and volunteer_profile_pic tables in the remote database - everything works. Before you merge:
|
Looks good! Really like the adjustment to use transactions. Let me know if you want me to take another look after resolving merge conflicts or any other changes 😄 |
Overview of Changes
Feel free to reach out on discord if you have any questions