Revert "Adds the Moodle 4.4 version of the Ilios Enrollment plugin." #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctam
requested changes
Oct 21, 2024
There was a problem hiding this comment.
Please also remove the related lines in the .gitmodules file to be complete.
You can also just run git rm <path-to-submodule>, and commit. It used to be a lot more work to do that, but the new git version makes it easier now.
(notify @mirleu and @stopfstedt here, too, on how to properly remove a git submodule.)
|
Hey, @lbailey-ucsf, what did you change? The tests in the GHA workflow start running again! 🥳 |
|
Oh, you created the PR branch here on this repo instead of your own fork, and that's why it got run here. 🙃 |
removed the following lines are requested by reviewer: [submodule "enrol/ilios"] path = enrol/ilios url = https://github.com/ilios/moodle-enrol-ilios branch = MOODLE_404_STABLE
|
@ctam did the GH_PAT expire? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #89
This commit appears to have caused phpUnit test failures and is being reverted.