Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UW-585: Build driver for SCHISM #506

Merged
merged 10 commits into from
Jun 13, 2024
Merged

UW-585: Build driver for SCHISM #506

merged 10 commits into from
Jun 13, 2024

Conversation

WeirAE
Copy link
Contributor

@WeirAE WeirAE commented Jun 10, 2024 •
edited
Loading

Synopsis

Build driver for SCHISM. As per discussion, scope is limited to "library" version for the coupled model.

AC:
new driver introduced in CLI and API
JSON Schema validation capability
Documentation for CLI, API and landing page addition

Type

  • Bug fix (corrects a known issue)
  • Code maintenance (refactoring, etc. without behavior change)
  • Documentation
  • Enhancement (adds new functionality)
  • Tooling (CI, code-quality, packaging, revision-control, etc.)

Impact

  • This is a breaking change (changes existing functionality)
  • This is a non-breaking change (existing functionality continues to work as expected)

Checklist

  • I have added myself and any co-authors to the PR's Assignees list.
  • I have reviewed the documentation and have made any updates necessitated by this change.

@WeirAE WeirAE self-assigned this Jun 10, 2024
maddenp-noaa
maddenp-noaa reviewed Jun 10, 2024
View reviewed changes
docs/sections/user_guide/yaml/components/schism.rst Show resolved Hide resolved
src/uwtools/drivers/schism.py Outdated Show resolved Hide resolved
src/uwtools/drivers/schism.py Outdated Show resolved Hide resolved
@WeirAE WeirAE marked this pull request as ready for review June 11, 2024 14:50
@WeirAE
Copy link
Contributor Author

WeirAE commented Jun 12, 2024

Really not sure why test__values_needed in test_jinja2.py is failing now in the 3.9.19 version, nothing here should affect that

christinaholtNOAA
christinaholtNOAA approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@christinaholtNOAA christinaholtNOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just one minor copy/paste error (I think).

src/uwtools/tests/drivers/test_schism.py Outdated Show resolved Hide resolved
@WeirAE WeirAE requested a review from maddenp-noaa June 12, 2024 22:34
maddenp-noaa
maddenp-noaa reviewed Jun 13, 2024
View reviewed changes
docs/sections/user_guide/yaml/components/schism.rst Outdated Show resolved Hide resolved
src/uwtools/drivers/schism.py Outdated Show resolved Hide resolved
src/uwtools/drivers/schism.py Outdated Show resolved Hide resolved
src/uwtools/resources/jsonschema/schism.jsonschema Outdated Show resolved Hide resolved
src/uwtools/tests/drivers/test_schism.py Outdated Show resolved Hide resolved
src/uwtools/tests/drivers/test_schism.py Outdated Show resolved Hide resolved
src/uwtools/tests/test_schemas.py Outdated Show resolved Hide resolved
maddenp-noaa
maddenp-noaa approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@maddenp-noaa maddenp-noaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left one comment about simplifying / generalizing the template_values item in the schism and ww3 schemas, but otherwise this looks good to me!

@WeirAE WeirAE merged commit dbe1224 into ufs-community:main Jun 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maddenp-noaa maddenp-noaa maddenp-noaa approved these changes

@christinaholtNOAA christinaholtNOAA christinaholtNOAA approved these changes

@NaureenBharwaniNOAA NaureenBharwaniNOAA Awaiting requested review from NaureenBharwaniNOAA NaureenBharwaniNOAA is a code owner

@elcarpenterNOAA elcarpenterNOAA Awaiting requested review from elcarpenterNOAA elcarpenterNOAA is a code owner

@fgabelmannjr fgabelmannjr Awaiting requested review from fgabelmannjr fgabelmannjr is a code owner

Assignees

@WeirAE WeirAE

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WeirAE @christinaholtNOAA @maddenp-noaa