Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UW-607 orog_gsl driver #509

Merged
merged 29 commits into from
Jun 13, 2024
Merged

UW-607 orog_gsl driver #509

merged 29 commits into from
Jun 13, 2024

Conversation

maddenp-noaa
Copy link
Contributor

@maddenp-noaa maddenp-noaa commented Jun 13, 2024 •
edited
Loading

Synopsis

A driver for the orog_gsl component from UFS-UTILS. If you're interested, you can look at an example execution at /home/Paul.Madden/git/uwtools/run on hera, configured via /home/Paul.Madden/git/uwtools/orog_gsl.yaml. I did a few bits of simple refactoring, as well, which explains the high file count. I'll comment on those inline.

Type

  • Documentation
  • Enhancement (adds new functionality)

Impact

  • This is a non-breaking change (existing functionality continues to work as expected)

Checklist

  • I have added myself and any co-authors to the PR's Assignees list.
  • I have reviewed the documentation and have made any updates necessitated by this change.

@maddenp-noaa maddenp-noaa self-assigned this Jun 13, 2024
@maddenp-noaa maddenp-noaa mentioned this pull request Jun 13, 2024
Merged
9 tasks
@maddenp-noaa maddenp-noaa marked this pull request as ready for review June 13, 2024 14:53
WeirAE
WeirAE approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@WeirAE WeirAE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see anything out of place at all, looks great!

christinaholtNOAA
christinaholtNOAA approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@christinaholtNOAA christinaholtNOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

src/uwtools/tests/drivers/test_chgres_cube.py Show resolved Hide resolved
NaureenBharwaniNOAA
NaureenBharwaniNOAA approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@NaureenBharwaniNOAA NaureenBharwaniNOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@maddenp-noaa maddenp-noaa merged commit 71bf1e8 into ufs-community:main Jun 13, 2024
2 checks passed
@maddenp-noaa maddenp-noaa deleted the uw-607-orog-gsl-driver branch June 13, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NaureenBharwaniNOAA NaureenBharwaniNOAA NaureenBharwaniNOAA approved these changes

@WeirAE WeirAE WeirAE approved these changes

@christinaholtNOAA christinaholtNOAA christinaholtNOAA approved these changes

@jprestop jprestop Awaiting requested review from jprestop

@elcarpenterNOAA elcarpenterNOAA Awaiting requested review from elcarpenterNOAA elcarpenterNOAA is a code owner

@fgabelmannjr fgabelmannjr Awaiting requested review from fgabelmannjr fgabelmannjr is a code owner

Assignees

@maddenp-noaa maddenp-noaa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maddenp-noaa @christinaholtNOAA @WeirAE @NaureenBharwaniNOAA