Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sombrero] Simplify classes used in benchmarks #239

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Conversation

giordano
Copy link
Member

Address #237 (comment). @mirenradia Can you please check this solves the issues you reported in the first post?

@mirenradia
Copy link
Contributor

This resolves all of the issues I mentioned in #237 except for the num_tasks problem and I can now run the ITT-sn benchmark (after manually setting num_tasks appropriately). However, I do get the following warning:

WARNING: skipping test 'SombreroBenchmarkScaling': test has one or more undefined parameters

@giordano
Copy link
Member Author

giordano commented Dec 4, 2023

I can reproduce that, as far as I understand it comes from the fact case_filter.generate(scaling_config) in

params = parameter(case_filter.generate(scaling_config))
is an empty list [], and so the parameter params is undefined. I'm not entirely sure how that benchmark is supposed to work, it was contributed by @mmesiti, maybe he can shed some light on this?

In any case I'm going ahead and merge this PR, as it addresses the previously reported issues.

@giordano giordano merged commit e95d8dd into main Dec 4, 2023
4 checks passed
@giordano giordano deleted the mg/sombrero-app branch December 4, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants