CLDR-17587 Add Haitian Creole #3948
Open
+52
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Scheduling - this should target v47 and be merged after main is branched for v46 |
1 task
srl295
requested changes
Aug 15, 2024
There was a problem hiding this comment.
Generally LGTM though:
- needs to wait for v47 - maybe better to keep this in draft until then?
- the explicit parentage fr -> ht is allowed but the parent locale was not set in this PR yet
- need to run spotless to cleanup the code ( see the
tools/README.md#spotlessdocs )
conradarcturus
force-pushed
the
CLDR-17587-Add-Haitian-Creole
branch
from
9117398
to
c8a5d95
Compare
|
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
conradarcturus
force-pushed
the
CLDR-17587-Add-Haitian-Creole
branch
from
2b6c2c6
to
80a80cb
Compare
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
conradarcturus
force-pushed
the
CLDR-17587-Add-Haitian-Creole
branch
from
80a80cb
to
5aea4db
Compare
|
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
|
@srl295 are there still any changes that need to be made? |
conradarcturus
had a problem deploying
to
cloudflare
GitHub Actions
Failure
conradarcturus
force-pushed
the
CLDR-17587-Add-Haitian-Creole
branch
from
7bce15a
to
63fc6b9
Compare
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
This adds core data for Haitian Creole so that in v47 we can fill out the information for this locale.
I had an error (regular spaces shouldn't be used, only non-breaking spaces) and it caused me to check online media for the Haitian creole number formats. What I would write in English as "1,234,567.89" is shown in a few different ways, depending on the source. Survey we at Meta gave to Haitian Creole linguists: "1 234 567,89" [Google Translate](https://translate.google.com/?sl=en&tl=ht&text=1%2C234%2C567.89&op=translate): "1.234.567,89": [Haitian Times](https://haitiantimes.com/2024/08/04/haitis-northwest-mythical-coast-anse-a-foleur-to-celebrate-140-years/): "1,234,567.89" er, that's not great that the different sources work differently. I'll follow the survey'd results for initializing the core data but I'll follow up with Haitian Creole experts when we enter their language's data into the CLDR Survey Tool.
conradarcturus
force-pushed
the
CLDR-17587-Add-Haitian-Creole
branch
from
63fc6b9
to
a0a084f
Compare
|
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
|
Since ddl/v47 is in a good state now -- this should be good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds core data for Haitian Creole so that in Fall 2024 / v47 we can fill out the information for this locale.
CLDR-17587
ALLOW_MANY_COMMITS=true