Optimization wollok game #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #328 +/- ##
==========================================
- Coverage 89.85% 89.80% -0.05%
==========================================
Files 28 29 +1
Lines 3212 3226 +14
Branches 584 586 +2
==========================================
+ Hits 2886 2897 +11
- Misses 171 173 +2
- Partials 155 156 +1 ☔ View full report in Codecov by Sentry. |
guillep
reviewed
Jan 6, 2025
guillep
reviewed
Jan 6, 2025
test/benchmarks.ts
Outdated
Comment on lines
32
to
47
| const deltaError = Math.max(0.1, expectedTime * 0.1) // 0.1 or 10 % | ||
| restore() | ||
|
|
||
| // console.info(`${message} - ${fqn} - ${time} ms (${iterations} iterations)`) | ||
| results.push({ message, fqn, time, iterations }) | ||
| time.should.be.closeTo(expectedTime, deltaError) | ||
| }) | ||
| } | ||
|
|
||
| benchmark('empty', 0.55) | ||
| benchmark('visuals_1', 0.4) | ||
| benchmark('visuals_100', 0.3) | ||
| benchmark('ticks_1', 0.8) | ||
| benchmark('ticks_100', 44) | ||
| benchmark('onCollide_1', 0.8) | ||
| benchmark('onCollide_100', 44) |
There was a problem hiding this comment.
Are these assertions portable on different machines / browsers / JS implementations?
There was a problem hiding this comment.
I just hope:
- to have some number more or less regular in the CI
- detect when the number changes a lot
PalumboN
force-pushed
the
optimization-wollok-game
branch
from
1b55a35 to
db4e5ed
Compare
PalumboN
commented
Jan 8, 2025
PalumboN
commented
Jan 8, 2025
fdodino
reviewed
Jan 8, 2025
ivojawer
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Run benchmarks]
^- esto hace que corran los benchmarks en el CI y ponga los resultados como comment del commit
Acá se mejora la performance de las natives críticas de Wollok Game en base a lo que había investigado @mind-ar en un PR/issue que no encontré.
La optimización que se implementa es evitar invocar los getters creados por properties en las natives de game (que, además, por querer optimizar de más tenía un bug).
Lo importante es que armé unos mini-benchmarks de game para medir esto.
De paso también abrí al puerta para poder compilar implementaciones nativas de cualquier método. Por ahora solo se hace para las properties (no solo de game, sino de todo el programa).
Quiero implementar más benchmarks del lenguaje antes de meterme con un compilador...
TODOs
Benchmarks en uqbar-project/wollok-language#236