refactor: return reordered items and parent from event #6657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomivirkki
reviewed
Sep 20, 2024
...arent/vaadin-dashboard-flow/src/main/java/com/vaadin/flow/component/dashboard/Dashboard.java
Show resolved
Hide resolved
|
tomivirkki
reviewed
Sep 23, 2024
Comment on lines
+67
to
+68
| * Returns the parent of the reordered items. Either a dashboard or a | ||
| * section. |
There was a problem hiding this comment.
I tried this locally and I'm always getting the Dashboard instance, even when reordering inside a section.
|
Closing in favour of #6660. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the
DashboardItemReorderEndEventto return the list of reordered items and their parent instead of the JSON array containing the node IDs of all items.Added API:
List<Component> getReorderedItems(): Returns the list of the reordered item and its sibling itemsHasWidgets getReorderedItemsParent(): Returns the parent of the reordered itemsRemoved API:
JsonArray getItems(): Returns the ordered items from the client sidePart of vaadin/platform#6626
Type of change
Refactor