refactor: update events based on web component event changes #6660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ugur-vaadin
changed the base branch from
feat/dashboard-reordered-event-getters
to
feat/dashboard
tomivirkki
approved these changes
Sep 24, 2024
ugur-vaadin
force-pushed
the
feat/dashboard-events-update
branch
from
daa359b
to
e2c67f0
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the events based on the changes in web component events.
Removed API:
Dashboard.addItemReorderStartListenerDashboard.addItemResizeStartListenerRenamed API:
Dashboard.addItemReorderEndListener->Dashboard.addItemMovedListenerDashboard.addItemResizeEndListener->Dashboard.addItemResizedListenerUpdated API for events:
DashboardItemMovedEventComponent getItem(): Returns the moved itemList<Component> getItems(): Returns the root level items of the dashboardOptional<DashboardSection> getSection(): Returns the section that contains the moved item, or an empty optional if the item is a direct child of the dashboardDashboardItemRemovedEventComponent getItem(): Returns the removed itemList<Component> getItems(): Returns the root level items of the dashboardDashboardItemResizedEventDashboardWidget getItem(): Returns the resized widgetList<Component> getItems(): Returns the root level items of the dashboardPart of vaadin/platform#6626
Type of change
Refactor