Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make default value optional for ValueSignal #3160

Merged
merged 16 commits into from
Jan 28, 2025

fix style

7f9f5f4
Select commit
Loading
Failed to load commit list.
Merged

feat: make default value optional for ValueSignal #3160

fix style
7f9f5f4
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 27, 2025 in 1s

92.84% (+0.19%) compared to 6de563d

View this Pull Request on Codecov

92.84% (+0.19%) compared to 6de563d

Details

Codecov Report

Attention: Patch coverage is 97.61905% with 4 lines in your changes missing coverage. Please review.

Project coverage is 92.84%. Comparing base (6de563d) to head (7f9f5f4).

Files with missing lines Patch % Lines
...ts/generator-plugin-signals/src/SignalProcessor.ts 97.61% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3160      +/-   ##
==========================================
+ Coverage   92.65%   92.84%   +0.19%     
==========================================
  Files          85       85              
  Lines        3187     3328     +141     
  Branches      778      800      +22     
==========================================
+ Hits         2953     3090     +137     
- Misses        182      186       +4     
  Partials       52       52              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.