Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make hybrid dev module a provided dependency #6918

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

mcollovati
Copy link
Contributor

@mcollovati mcollovati commented Oct 24, 2024

vaadin-dev-bundle requires vaadin-hybrid-dev-bundle only to extract the hybrid
package-lock.json file. It necessary to have the hybrid bundle module as a
project dependency, to make sure modules are executed in the correct order by
maven reactor. However, the scope of the hybrid dependency must be provided
to prevent the flow maven plugin to find its stats.json in classpath and
then refusing to create a new dev bundle.

Copy link

github-actions bot commented Oct 24, 2024

Dependencies Report

  • 🚫 Vulnerabilities:

  • 🟠 Known Vulnerabilities:

    • Vulnerabilities in: pkg:npm/[email protected] [CVE-2024-34394, CVE-2024-34393] (osv-scan)
      👌 This is coming from the tools, @cyclonedx/cyclonedx, we have used for sbom module, FP for us.
      ·
    • Vulnerabilities in: pkg:maven/com.fasterxml.jackson.core/[email protected] [CVE-2023-35116] (owasp)
      👌 Not a valid CVE report based on the vendor analysis and research
      · cpe:2.3:a:fasterxml:jackson-databind::::::::
    • Vulnerabilities in: pkg:maven/me.friwi/jcef-api@jcef-af53d63%2Bcef-104.4.23%2Bg46ae630%2Bchromium-104.0.5112.102 [CVE-2024-21639, CVE-2024-21640] (owasp)
      👌 Wait for the update from the jcefmaven community. Meanwhile the swing-kit is supposed to be used with fixed websites and not to browse the internet, we have a check for that, so the only possible attacker would be the same person that created the swing application, aka our customer devs. so this vulnerability is not classified by us as critical issue
      · cpe:2.3:a:chromiumembedded:chromium_embedded_framework::::::::
  • 📔 No License Issues

  • 🟠 Changes in 24.6-SNAPSHOT since V24.6.0.alpha1

    • 31 packages removed (31 external, 0 vaadin)
    • 1 packages added (1 external, 0 vaadin)
    • 6 packages modified (6 external, 0 vaadin)
    • 1023 packages same (798 external, 225 vaadin)

[Click for more Details]

vaadin-dev-bundle requires vaadin-hybrid-dev-bundle only to extract the hybrid
package-lock.json file. It necessary to have the hybrid bundle module as a
project dependency, to make sure modules are executed in the correct order by
maven reactor. However, the scope of the hybrid dependency must be provided
to prevent the flow maven plugin to find its stats.json in classpath and
then refusing to create a new dev bundle.
@mcollovati mcollovati force-pushed the chore/remove-unnecessary-dependency branch from bcc87e3 to 5839fd2 Compare October 24, 2024 10:36
@mcollovati mcollovati changed the title chore: remove unnecessary dependency to hybrid dev module chore: make hybrid dev module a provided dependency Oct 24, 2024
<dependency>
<groupId>${project.groupId}</groupId>
<artifactId>vaadin-hybrid-dev-bundle</artifactId>
<version>${project.version}</version>
<scope>provided</scope>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it a breaking change that requires this dependency to be added into hybrid projects?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, that dependency is used only for platform build

@ZheSun88 ZheSun88 enabled auto-merge (squash) October 25, 2024 06:03
@ZheSun88 ZheSun88 merged commit 16ad124 into main Oct 25, 2024
2 of 3 checks passed
@ZheSun88 ZheSun88 deleted the chore/remove-unnecessary-dependency branch October 25, 2024 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants