-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: make hybrid dev module a provided dependency #6918
Conversation
Dependencies Report
|
vaadin-dev-bundle requires vaadin-hybrid-dev-bundle only to extract the hybrid package-lock.json file. It necessary to have the hybrid bundle module as a project dependency, to make sure modules are executed in the correct order by maven reactor. However, the scope of the hybrid dependency must be provided to prevent the flow maven plugin to find its stats.json in classpath and then refusing to create a new dev bundle.
bcc87e3
to
5839fd2
Compare
<dependency> | ||
<groupId>${project.groupId}</groupId> | ||
<artifactId>vaadin-hybrid-dev-bundle</artifactId> | ||
<version>${project.version}</version> | ||
<scope>provided</scope> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it a breaking change that requires this dependency to be added into hybrid projects?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, that dependency is used only for platform build
vaadin-dev-bundle requires vaadin-hybrid-dev-bundle only to extract the hybrid
package-lock.json file. It necessary to have the hybrid bundle module as a
project dependency, to make sure modules are executed in the correct order by
maven reactor. However, the scope of the hybrid dependency must be provided
to prevent the flow maven plugin to find its stats.json in classpath and
then refusing to create a new dev bundle.