Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix padding rows in Mul32Chip #95

Merged
merged 1 commit into from
Jan 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions alu_u32/src/mul/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -50,12 +50,10 @@ where
}

// Encode dummy operations as needed to pad the trace.
let dummy_op = Operation::Mul32(Word::default(), Word::default(), Word::default());
for i in num_ops..num_padded_ops {
let row = &mut values[i * NUM_MUL_COLS..(i + 1) * NUM_MUL_COLS];
let cols: &mut Mul32Cols<F> = row.borrow_mut();
cols.counter = F::from_canonical_usize(i + 1);
self.op_to_row(&dummy_op, cols);
}

RowMajorMatrix {
Expand Down
1 change: 0 additions & 1 deletion basic/tests/test_prover.rs
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ use rand::thread_rng;
use valida_machine::__internal::p3_commit::ExtensionMmcs;

#[test]
#[ignore] // TODO: Bus arguments are failing?
fn prove_fibonacci() {
let mut program = vec![];

Expand Down
Loading