Fix padding rows in Mul32Chip
#95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously padding rows had `is_mul = 1` and `is_real = 0`; the latter had the effect of excluding these rows from the bus argument. Now inclusion in the bus argument is instead controlled by `is_mul + is_mulhs + is_mulhu`, so padding rows can't have `is_mul = 1` as they did before. The multiplication constraints should be satisfied on an all-zero row, so I think it's easiest to leave the zeros, except for the `counter` column which must be populated for range checks to work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously padding rows had
is_mul = 1andis_real = 0; the latter had the effect of excluding these rows from the bus argument.Now inclusion in the bus argument is instead controlled by
is_mul + is_mulhs + is_mulhu, so padding rows can't haveis_mul = 1as they did before.The multiplication constraints should be satisfied on an all-zero row, so I think it's easiest to leave the zeros, except for the
countercolumn which must be populated for range checks to work.