-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(vrl): Add parse_cbor vrl function documentation #22082
base: master
Are you sure you want to change the base?
Conversation
176b260
to
ca737fa
Compare
ca737fa
to
4384f1c
Compare
remap: functions: parse_json: { | ||
category: "Parse" | ||
description: """ | ||
Parses the `value` as CBOR (https://cbor.io). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is markdown syntax valid in cue? I dont know if this works
Parses the `value` as CBOR (https://cbor.io). | |
Parses the `value` as [CBOR](https://cbor.io). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Edit: This should work as is.
Here's an example on how we usually do URLs in docs: https://github.com/vectordotdev/vector/blob/master/website/cue/reference/remap/functions/decode_base16.cue#L6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved to urls.cue
and added as a link
@@ -0,0 +1,36 @@ | |||
package metadata | |||
|
|||
remap: functions: parse_json: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remap: functions: parse_json: { | |
remap: functions: parse_cbor: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed typo
4384f1c
to
f26b633
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @MiracleWisp 👍
And thanks @jorgehermo9 for the review.
Summary
Change Type
Is this a breaking change?
How did you test this PR?
Does this PR include user facing changes?
Checklist
Cargo.lock
), pleaserun
dd-rust-license-tool write
to regenerate the license inventory and commit the changes (if any). More details here.References
Relates to vectordotdev/vrl#1152