feat(parse_cbor): add parse_cbor function #1152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiracleWisp
force-pushed
the
cbor_support
branch
6 times, most recently
from
8d6a19d to
1ca2e81
Compare
MiracleWisp
changed the title
MiracleWisp
force-pushed
the
cbor_support
branch
from
1ca2e81 to
554d4d0
Compare
pront
approved these changes
Dec 2, 2024
MiracleWisp
force-pushed
the
cbor_support
branch
from
b1d7103 to
1ecef46
Compare
MiracleWisp
force-pushed
the
cbor_support
branch
3 times, most recently
from
dd269f4 to
4193d5f
Compare
MiracleWisp
force-pushed
the
cbor_support
branch
from
4193d5f to
38f70bb
Compare
pront
reviewed
Dec 13, 2024
| @@ -0,0 +1,2 @@ | |||
| [overrides] | |||
There was a problem hiding this comment.
I don't recall what's the function of this. Did you run dd-rust-license-tool?
There was a problem hiding this comment.
dd-rust-licence-tool fails without this config because "crunchy" package doesn't have repository config in cargo.toml
eira-fransham/crunchy#9
There was a problem hiding this comment.
Ah I see, this makes sense. That repository seems abandoned but licenses are fine.
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In this PR I would like to add support for cbor. We use this format as an alternative to JSON for more efficient data transfer to Kafka. And we would really like to be able to use vector in our projects
Change Type
Is this a breaking change?
How did you test this PR?
Unit tests are provided in this PR
Does this PR include user facing changes?
our guidelines.
Checklist
run
dd-rust-license-tool writeand commit the changes. More details here.References