build: switch bundler for deploy previews back to parcel #9362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying vega-lite with
|
| Latest commit: |
78cb4a5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f4e83ea7.vega-lite.pages.dev |
| Branch Preview URL: | https://cameron-yick-fix-deploy-prev.vega-lite.pages.dev |
hydrosquall
force-pushed
the
cameron.yick/fix-deploy-previews-vite
branch
from
c4db71f
to
78cb4a5
Compare
domoritz
approved these changes
May 31, 2024
hydrosquall
added a commit
to vega/vega
that referenced
this pull request
Jun 12, 2024
## Motivation - Repeat vega/vega-lite#9362, but for vega repo instead of vega-lite. Build broke after we changed from vite back to parcel - Noticed build preview was failing for a recent PR for reasons unrelated to that change ( #3930 (comment) ) ## Changes - Update the build command to match what we have in vega-lite (remove the dependency on vite) ## Testing The cloudflare deploy preview should succeed on this branch (watch for comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Changes
Testing