Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: switch bundler for deploy previews back to parcel #9362

Merged
merged 3 commits into from
May 31, 2024
Merged

build: switch bundler for deploy previews back to parcel #9362

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9639bac
build: switch bundler for deploy previews back to parcel
hydrosquall May 31, 2024
1d57025
fix: disable sourcemaps as they exceed CDN limit
hydrosquall May 31, 2024
78cb4a5
build: disable minification so that sourcemaps are readable
hydrosquall May 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions scripts/build-editor-preview.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,13 @@

set -eo pipefail

# Build the docs site and replace the main build with the local copy of vega-lite
echo "Attempting install"
# apt install rsync
# Build the editor site and replace the main build with the local copy of vega-lite
echo "Starting install"

yarn build
yarn link
git clone https://github.com/vega/editor.git

#
cd editor
yarn --frozen-lockfile --ignore-scripts
yarn link vega-lite
Expand All @@ -32,5 +30,7 @@ cat <<EOF > public/spec/vega/index.json
{}
EOF

# TBD if some vendor files are needed
yarn run vite build --base /
# Build the editor site in the dist folder
# Disable minification to make it easier to debug, and because sourcemaps
# exceed 25 MB limit on cloudflare
yarn run build:only --public-url / --no-optimize --no-source-maps