Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RSDK-9778: add resource base stubs to python modules #4742

Merged
merged 2 commits into from
Jan 29, 2025
Merged

RSDK-9778: add resource base stubs to python modules #4742

merged 2 commits into from
Jan 29, 2025

Conversation

purplenicole730
Copy link
Member

@purplenicole730 purplenicole730 commented Jan 24, 2025 •
edited
Loading

Changes:

  • generated module resources will now include async functions from ComponentBase or ServiceBase

Arm Component:
arm_imports
arm_commands
Vision Service:
vision_commands

@viambot viambot added the safe to test This pull request is marked safe to test from a trusted zone label Jan 24, 2025
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Jan 24, 2025
@purplenicole730 purplenicole730 marked this pull request as ready for review January 24, 2025 20:42
stuqdog
stuqdog approved these changes Jan 27, 2025
View reviewed changes
Copy link
Member

@stuqdog stuqdog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thanks for getting this done so quickly!

@purplenicole730 purplenicole730 merged commit 2c20e8d into viamrobotics:main Jan 29, 2025
16 checks passed
@purplenicole730 purplenicole730 deleted the RSDK-9778-add-resource-base-stubs-to-python-modules branch January 29, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuqdog stuqdog stuqdog approved these changes

Assignees
No one assigned
Labels
safe to test This pull request is marked safe to test from a trusted zone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@purplenicole730 @stuqdog @viambot