Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

s/訳註/訳注/ #1697

Merged
merged 2 commits into from
Sep 27, 2024
Merged

s/訳註/訳注/ #1697

merged 2 commits into from
Sep 27, 2024

Conversation

Milly
Copy link
Contributor

@Milly Milly commented Sep 26, 2024

No description provided.

@Milly Milly requested a review from k-takata September 26, 2024 18:25
k-takata
k-takata approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@k-takata k-takata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

「註」は常用外漢字ですし、積極的にそれを使う理由も無いように思いますので、いいと思います。

tsuyoshicho
tsuyoshicho approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@tsuyoshicho tsuyoshicho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@k-takata k-takata merged commit e8a9bf3 into master Sep 27, 2024
3 checks passed
@k-takata k-takata deleted the fix-yakuchu branch September 27, 2024 01:23
@k-takata
Copy link
Member

thx

@Milly
Copy link
Contributor Author

Milly commented Sep 27, 2024

主な理由は syntax が適用されないからです。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k-takata k-takata k-takata approved these changes

@h-east h-east h-east approved these changes

@tsuyoshicho tsuyoshicho tsuyoshicho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Milly @k-takata @tsuyoshicho @h-east