-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make DSLs use metamodels instead of VitruvDomains #502
Conversation
f900434
to
c9f7317
Compare
c9f7317
to
84c84de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we use EPackage
is multiple locations instead of the MetamodelDescriptor
?
Besides that looks fine to me. Explicitly importing metamodels for the Commonalities is a good scoping improvement 👍🏼 .
...s.commonalities/src/tools/vitruv/dsls/commonalities/language/elements/MetamodelAdapter.xtend
Outdated
Show resolved
Hide resolved
....dsls.reactions.tests/src/tools/vitruv/dsls/reactions/builder/ComplexRoutineLogicTests.xtend
Outdated
Show resolved
Hide resolved
Thanks for the feedback and good question. I also thought about using some metamodel concept instead of |
....dsls.reactions.tests/src/tools/vitruv/dsls/reactions/builder/ComplexRoutineLogicTests.xtend
Outdated
Show resolved
Hide resolved
I see. The optimal solution from my perspective was a computed accessor for the |
A We can either
In the latter case, we could also add a |
If it is a valid scenario that the registry misses some |
Alright, I agree. So this PR is ready to merge, isn't it? |
This PR makes the DSLs (Reactions, Mappings, Commonalities) independent from
VitruvDomains
.VitruvDomains
and generates appropriate code for theChangePropagationSpecifications
that have already been adapted to use metamodels wrapping namespace URIs rather thanVitruvDomains
in Separate change propagation from VirtualModel #501.VitruvDomains
.It also updates the features and the updatesite categories to separate the change part (with specification, propagation and dsls) and the V-SUM part (views, vsum, domains, applications) of the framework.