Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix translations related to payments in full #125

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Fix translations related to payments in full #125

merged 1 commit into from
Nov 11, 2024

Conversation

GeorgeLimaDev
Copy link
Contributor

@GeorgeLimaDev GeorgeLimaDev commented Nov 4, 2024

What problem is this solving?

It relates to the task LOC-16987 which fixes translations of the expression "In spot" for payments made in just one installment.

Copy link

vtex-io-ci-cd bot commented Nov 4, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Nov 4, 2024

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

Copy link

github-actions bot commented Nov 4, 2024

Fails
🚫

We follow keepachangelog standards.

Please, add a section to your changelog entry. Example:

 ## [Unreleased]

+ ### Fixed
 - Issue with image sizing in the SKU Selector.

You can use one of the following sections:

  • Added for new features.
  • Changed for changes in existing functionality.
  • Deprecated for soon-to-be removed features.
  • Removed for now removed features.
  • Fixed for any bug fixes.
  • Security in case of vulnerabilities.

Generated by 🚫 dangerJS against 3529b0f

Copy link
Contributor

@sheilagomes sheilagomes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iago1501 iago1501 merged commit 4ddfbd0 into master Nov 11, 2024
9 of 10 checks passed
@iago1501 iago1501 deleted the loc/16987 branch November 11, 2024 13:37
Copy link

vtex-io-ci-cd bot commented Nov 11, 2024

Your PR has been merged! App is being published. 🚀
Version 1.31.0 → 1.31.1

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants