fix: use correct offset when converting commitment to bigint #103
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function that converts a
Uint8Array
tobigint
was using aDataView
to access the underlying buffer representing the credentials generated from zerokit. By accessing the buffer of asubarray
directly without specifying the offset, it reads bytes from the beginning of the buffer, which results in thebigint
representation ofIdTrapdoor
NOTIdCommitment
. Applications using the library to generate credentials would end up sending the wrong value to the RLN smart contract.Fix is to add the correct offset to the
DataView
.