feat(filter): reliability monitor as a separate class to handle reliability logic #2105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
size-limit report 📦
|
danisharora099
changed the title
danisharora099
changed the title
danisharora099
force-pushed
the
feat/reliability-monitor
branch
2 times, most recently
from
c7767dc
to
ca44b9c
Compare
weboko
reviewed
Aug 26, 2024
| @@ -0,0 +1,4 @@ | |||
| export const DEFAULT_KEEP_ALIVE = 30 * 1000; | |||
There was a problem hiding this comment.
nit: let's move filter folder to src
There was a problem hiding this comment.
it is under src/protocols - do you mean root of src?
weboko
reviewed
Aug 26, 2024
| this.pubsubTopic = pubsubTopic; | ||
| this.subscriptionCallbacks = new Map(); | ||
|
|
||
| this.reliabilityMonitor = new ReliabilityMonitor( |
There was a problem hiding this comment.
based on the original design - we'd need to use it in lightPush too
or do you have another idea how to make retry there happen?
There was a problem hiding this comment.
correct. i want to split the PR such that there is cleaner diff and this PR can be followed up with lightpush changes similar to filter (this PR)
weboko
reviewed
Aug 26, 2024
| } | ||
| } | ||
|
|
||
| public resetPeerStats(peerIdStr: string): void { |
There was a problem hiding this comment.
nit: let's have public methods on top of the file
|
Have you tried it in |
danisharora099
force-pushed
the
feat/reliability-monitor
branch
from
b6de656
to
4d20c67
Compare
|
superseded by #2117 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Based on #2075, the logic to detect messages that were missed from the Filter protocol were being detected inside of the Filter SDK implementation. This leads to a tight couple of primary objective of FilterSDK, and reliability goals.
This obstacle also extends to adding further actions that might be taken with additional protocols such as Store pings, and LightPush retries for certain messages.
Solution
Decouple reliability logic into a new ReliabilityMonitor class.
Notes
Contribution checklist:
!in title if breaks public API;