fix: remove quotes from libwaku's returned enr string #3097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielmer
requested review from
Ivansete-status,
richard-ramos,
darshankabariya and
NagyZoltanPeter
richard-ramos
approved these changes
Oct 7, 2024
|
You can find the image built from this PR at Built from eb46d96 |
Ivansete-status
approved these changes
Oct 7, 2024
| @@ -30,7 +30,7 @@ proc process*( | |||
| of RETRIEVE_LISTENING_ADDRESSES: | |||
| return ok($(%*waku.node.getMultiaddresses())) | |||
| of RETRIEVE_MY_ENR: | |||
| return ok($(%*waku.node.enr.toURI())) | |||
| return ok(waku.node.enr.toURI()) | |||
There was a problem hiding this comment.
Maybe we need to do the same with the other cases
There was a problem hiding this comment.
There's only one additional case, RETRIEVE_LISTENING_ADDRESSES, and I think it's needed there because the result of getMultiaddresses()is a sequence, so we need to convert the sequence to a string. However, I'm not sure why it was implemented this way and not just used the $ operator on the sequence
There was a problem hiding this comment.
I'll go ahead and merge this change, and once we get to the usage of RETRIEVE_LISTENING_ADDRESSES will revisit if the %* is necessary or not, but their case is definitely different and makes more sense
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In libwaku, when processing a
RETRIEVE_MY_ENRrequest we are adding an extra"in the beginning and in the end of the string.This is necessary for
RETRIEVE_LISTENING_ADDRESSESbecause we have to convert a sequence to a string, but forRETRIEVE_MY_ENRwhich already has a return type of type string, this ends up adding extra quotes.Changes
RETRIEVE_MY_ENRas isIssue
#3039