Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove quotes from libwaku's returned enr string #3097

Merged
merged 2 commits into from
Oct 8, 2024
Merged

fix: remove quotes from libwaku's returned enr string #3097

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f44334b
fix libwaku's returned enr string
gabrielmer Oct 7, 2024
60b2728
Merge branch 'master' into fix-libwaku-enr-string
gabrielmer Oct 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion library/waku_thread/inter_thread_communication/requests/debug_node_request.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ proc process*(
of RETRIEVE_LISTENING_ADDRESSES:
return ok($(%*waku.node.getMultiaddresses()))
of RETRIEVE_MY_ENR:
return ok($(%*waku.node.enr.toURI()))
return ok(waku.node.enr.toURI())
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we need to do the same with the other cases

Copy link
Contributor Author

@gabrielmer gabrielmer Oct 8, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's only one additional case, RETRIEVE_LISTENING_ADDRESSES, and I think it's needed there because the result of getMultiaddresses()is a sequence, so we need to convert the sequence to a string. However, I'm not sure why it was implemented this way and not just used the $ operator on the sequence

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll go ahead and merge this change, and once we get to the usage of RETRIEVE_LISTENING_ADDRESSES will revisit if the %* is necessary or not, but their case is definitely different and makes more sense


error "unsupported operation in DebugNodeRequest"
return err("unsupported operation in DebugNodeRequest")
Loading