Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rules for ESLint 2.0.0 #68

Closed
wants to merge 11 commits into from
Closed

Conversation

lkrnac
Copy link
Contributor

@lkrnac lkrnac commented Feb 13, 2016

After upgrade to ESLint 2.0.0, there were these failures:

  1:1  error  Rule 'no-empty-label' was removed and replaced by: no-labels                 no-empty-label
  1:1  error  Rule 'space-after-keywords' was removed and replaced by: keyword-spacing     space-after-keywords
  1:1  error  Rule 'space-before-keywords' was removed and replaced by: keyword-spacing    space-before-keywords
  1:1  error  Rule 'space-return-throw-case' was removed and replaced by: keyword-spacing  space-return-throw-case

These rules were removed.
This pull request aims to migrate configuration for removed rules.

It was removed in new ESLint version 2.x
There are breaking changes because previously some rule
sets had space-after-keywords enabled and
space-before-keyword disabled. Such situation doesn't seem
to be covered by replacement rule keyword-spacing
@Panda-ref
Copy link

Merge please.

@lkrnac lkrnac mentioned this pull request Feb 24, 2016
@baer
Copy link
Contributor

baer commented Feb 25, 2016

Hi @lkrnac! Thanks so much for the PR - I dono what's going on but I didn't get an email for this. Sorry for the delay. I have a few comments though before I can merge it:

  1. The package.json only gets bumped when a release is cut, not on every PR so that part will have to go.
  2. Please rebase your commits if you could - I like to try to keep history as clean as I can.

Unfortunately, this PR is not sufficient to upgrade to ESLint 2.0 by itself but it's a great step and is a huge help to me so thanks a bunch for your work. I'll create a new issue to track the rest of it. Once you've made those two changes I'll merge this.

Thanks again.

@baer
Copy link
Contributor

baer commented Feb 25, 2016

Here's the comment that outlines the remaining work to get on ESLint 2.0. PRs are of course welcome but I'll be getting to it as I have time

#69 (comment)

@lkrnac
Copy link
Contributor Author

lkrnac commented Feb 27, 2016

@bear, OK, np. I closed this one and opened separate PR (#71), without problematic commit.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants