-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update rules for ESLint 2.0.0 #68
Conversation
It was removed in new ESLint version 2.x
There are breaking changes because previously some rule sets had space-after-keywords enabled and space-before-keyword disabled. Such situation doesn't seem to be covered by replacement rule keyword-spacing
Merge please. |
Hi @lkrnac! Thanks so much for the PR - I dono what's going on but I didn't get an email for this. Sorry for the delay. I have a few comments though before I can merge it:
Unfortunately, this PR is not sufficient to upgrade to ESLint 2.0 by itself but it's a great step and is a huge help to me so thanks a bunch for your work. I'll create a new issue to track the rest of it. Once you've made those two changes I'll merge this. Thanks again. |
Here's the comment that outlines the remaining work to get on ESLint 2.0. PRs are of course welcome but I'll be getting to it as I have time |
It was removed in new ESLint version 2.x
Conflicts: package.json
After upgrade to ESLint 2.0.0, there were these failures:
These rules were removed.
This pull request aims to migrate configuration for removed rules.