Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve breaking changes after update to ESLint 2.0.0 #71

Merged
merged 4 commits into from
Mar 4, 2016

Conversation

lkrnac
Copy link
Contributor

@lkrnac lkrnac commented Feb 27, 2016

This pull request replaces this one: #68
It doesn't contain major version bump.

This was referenced Feb 27, 2016
@tgandrews
Copy link

This looks good. 👍

@divmain
Copy link

divmain commented Mar 4, 2016

@lkrnac since this resolves some issues for me, I've published your PR as @divmain/eslint-config-defaults. Looks like there are some other requirements that @baer has in mind for full ESLint v2 compatibility, so I'll unpublish as soon as #69 is closed.

@baer
Copy link
Contributor

baer commented Mar 4, 2016

I'm going to merge this, remove the package.json bump to 2.x and publish as a patch. This should unbreak those early adopters that just cannot wait to use eslint 2 before I can finish the work to fully convert this lib.

Hope this helps @divmain @tgandrews @lkrnac. Thanks for the contribution!.

baer added a commit that referenced this pull request Mar 4, 2016
Solve breaking changes after update to ESLint 2.0.0
@baer baer merged commit 942eba4 into walmartlabs:master Mar 4, 2016
@baer
Copy link
Contributor

baer commented Mar 4, 2016

Okay, I merged this to master but I can't publish without doing a major rev since this replaces rules from 1.x with rules added in 2.x. For this reason I have to hold off on releasing until 2.x work is further along. You can depend on master in your project if you'd like though...

Sorry :(

@divmain
Copy link

divmain commented Mar 5, 2016

@baer, could you do a pre-major release? That would allow folks to explicitly use these changes, it wouldn't effect current ESLint 1.x users, and it would indicate that this is an iteration in the direction of a break-change-release. Something like:

npm version premajor
npm publish --tag alpha

Then folks could do:

npm install eslint-config-defaults@alpha

@divmain
Copy link

divmain commented Mar 5, 2016

Also, thanks :)

@baer
Copy link
Contributor

baer commented Mar 5, 2016

😩 Damn you npm

npm ERR! Tag name must not be a valid SemVer range: 10.0.0-alpha1
npm ERR! Tag name must not be a valid SemVer range: 10.0.0-alpha.1
npm ERR! Tag name must not be a valid SemVer range: 10.0.0-1

@baer
Copy link
Contributor

baer commented Mar 9, 2016

screen shot 2016-03-09 at 3 16 16 pm

Published @Alpha. Sorry for the delay.

@lkrnac lkrnac deleted the pull-request branch March 10, 2016 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants