ELEX-3031: Potential Voterflow Solvers #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…un and also to inherit from TransitionSolver
…rformed before the cvxpy solver
…he EI solver and also experimenting with different sampler options there
…centages to sum to 1 at the unit-level
…ing_chains argument is an int
…out to change (also squashes warning)
…ELEX-3031-voterflow-models
…ts are available for 3.10
…rrent version of pytensor
|
Hi @lennybronner 👋🏻 Alright, I think this is officially ready for review! Looking forward to addressing all your questions/comments/concerns 😄 🎉 In particular, please take a look at how I implemented weighting in the matrix solver. I'm curious if I got something wrong there and that's why we're having problems with weighting + stratifying 🤔 Thanks!! |
…living in the ELEX-3830 branch
…untimeError and raise the exception
…ented anywhere yet
…ver to elex-voterflow-model
…self._betas', renaming 'weights' to 'sample_weight' to be consistent with sklearn
…itionSolver/TransitionMatrixSolver
… transition solvers 🎉
|
Hi @lennybronner I removed the requirement of everything having to be integers here and updated the unit tests 🎉 Let me know what you think and I'll make sure |
lennybronner
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR provides
threeone potential transition solver and a base class 🎉Work on bootstrapping the matrix solver is still in-progress and can be found in this branch.
The EI solver is now the EI model and is part of elex-voterflow-model, where it is still a subclass of
TransitionSolver.Jira Ticket
ELEX-3031
Test Steps
tox!