Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zoobot/feature/data sources #401

Merged
merged 8 commits into from
Mar 20, 2023
Merged

Zoobot/feature/data sources #401

merged 8 commits into from
Mar 20, 2023

Conversation

zoobot
Copy link
Member

@zoobot zoobot commented Jan 13, 2023

No description provided.

@zoobot zoobot mentioned this pull request Feb 12, 2023
Closed
@zoobot zoobot self-assigned this Feb 12, 2023
This was linked to issues Feb 12, 2023
[New Feature Implementation] Implement new design of "Tree Sources / Data" page plus specific sources #282
Closed
Create front-end for adding new data sources #275
Closed
@zoobot zoobot mentioned this pull request Feb 17, 2023
Open
6 tasks
@zoobot zoobot force-pushed the zoobot/feature/data-sources branch 2 times, most recently from 72e0f8c to 3950742 Compare March 11, 2023 16:51
@zoobot zoobot force-pushed the zoobot/feature/data-sources branch from 3950742 to b5240ae Compare March 11, 2023 21:37
@zoobot zoobot marked this pull request as ready for review March 14, 2023 18:20
@zoobot zoobot mentioned this pull request Mar 14, 2023
Merged
@zoobot zoobot requested review from mwpark2014 and tzinckgraf March 14, 2023 19:17
@zoobot
Copy link
Member Author

zoobot commented Mar 14, 2023

The new source route is ready to go, requires all these PRs to go in at once. Thanks for looking.
You can run server tests with npm test -- sources.test.js
Front end snapshot tests with npm test

waterthetrees/wtt_db#50

#401

waterthetrees/wtt_server#126

@zoobot zoobot mentioned this pull request Mar 14, 2023
Merged
@zoobot
Copy link
Member Author

zoobot commented Mar 15, 2023

@camille-le This source UI was your idea!! Thank you!

mwpark2014
mwpark2014 approved these changes Mar 18, 2023
View reviewed changes
Copy link
Contributor

@mwpark2014 mwpark2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fat PR! This looks like a lot of work, nice!

Overall looks fine. Let me know when it's merged and I can keep an eye out next time I poke around the app

client/src/api/apiEndpoints.js Show resolved Hide resolved
client/src/components/App/App.css Outdated Show resolved Hide resolved
client/src/components/Button/Button.js Outdated Show resolved Hide resolved
client/src/components/CSVImporter/CSVImporter.js Show resolved Hide resolved
client/src/tests/Source.test.js Show resolved Hide resolved
client/src/components/PanelDrawer/PanelDrawer.js Outdated Show resolved Hide resolved
client/src/components/ListGrid/ListGrid.js Outdated Show resolved Hide resolved
@zoobot zoobot merged commit 682a061 into main Mar 20, 2023
@zoobot zoobot deleted the zoobot/feature/data-sources branch March 25, 2023 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwpark2014 mwpark2014 mwpark2014 approved these changes

@tzinckgraf tzinckgraf Awaiting requested review from tzinckgraf

Assignees

@zoobot zoobot

Labels
None yet
Projects
Water the Trees
Status: Help Wanted
Milestone
No milestone
2 participants
@zoobot @mwpark2014