Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zoobot/feature/data sources #126

Merged
merged 21 commits into from
Mar 20, 2023
Merged

Zoobot/feature/data sources #126

merged 21 commits into from
Mar 20, 2023

Conversation

zoobot
Copy link
Member

@zoobot zoobot commented Feb 14, 2023

No description provided.

@zoobot zoobot force-pushed the zoobot/feature/data-sources branch from a33767d to 4234ba6 Compare February 14, 2023 17:42
@zoobot zoobot marked this pull request as ready for review February 14, 2023 17:51
@zoobot zoobot requested a review from tzinckgraf February 14, 2023 17:52
@zoobot zoobot marked this pull request as draft February 14, 2023 17:52
@zoobot zoobot mentioned this pull request Feb 17, 2023
Open
6 tasks
@zoobot zoobot marked this pull request as ready for review March 14, 2023 18:21
@zoobot
Copy link
Member Author

zoobot commented Mar 14, 2023 •
edited
Loading

The new source route is ready to go, requires all these PRs to go in at once. Thanks for looking.
You can run server tests with npm test -- sources.test.js
Front end snapshot tests with npm test

waterthetrees/wtt_db#50

waterthetrees/wtt_front#401

#126

@zoobot zoobot requested a review from mwpark2014 March 14, 2023 19:15
This was referenced Mar 14, 2023
Merged
Merged
tzinckgraf
tzinckgraf reviewed Mar 16, 2023
View reviewed changes
server/index.js Outdated Show resolved Hide resolved
@zoobot
Copy link
Member Author

zoobot commented Mar 20, 2023

@tzinckgraf resolved all conversations, this is ready to squash and merge once approved. Thanks for the review!!

@zoobot zoobot merged commit 5c95bb5 into main Mar 20, 2023
@zoobot zoobot deleted the zoobot/feature/data-sources branch March 20, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzinckgraf tzinckgraf tzinckgraf approved these changes

@mwpark2014 mwpark2014 Awaiting requested review from mwpark2014

Assignees
No one assigned
Labels
None yet
Projects
Water the Trees
Status: Help Wanted
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sources Integration with FE and vector tiles and db
2 participants
@zoobot @tzinckgraf