Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

By route and cleaning #124

Closed
wants to merge 10 commits into from
Closed

By route and cleaning #124

wants to merge 10 commits into from

Conversation

diazrenata
Copy link
Member

Summarize at route level and clean using functions from weecology/bbs-forecasting.

@codecov-io
Copy link

codecov-io commented May 10, 2019

Codecov Report

Merging #124 into bbs will decrease coverage by 4.11%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##              bbs    #124      +/-   ##
=========================================
- Coverage   68.72%   64.6%   -4.12%     
=========================================
  Files          13      14       +1     
  Lines         518     551      +33     
=========================================
  Hits          356     356              
- Misses        162     195      +33
Impacted Files Coverage Δ
R/get_retriever_data.R 0% <0%> (ø) ⬆️
R/bbs_cleaning_functions.R 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 512846c...7cb0db8. Read the comment docs.

@diazrenata diazrenata requested review from ha0ye and gmyenni May 10, 2019 22:59
Copy link
Contributor

@gmyenni gmyenni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only had time to skim this before leaving town, but LGTM!!

@diazrenata
Copy link
Member Author

#125 I made an initial attempt at handling all the BBS data at once. It appears to work (... 🔮) but it might be buggy and it might break some dependencies.

@diazrenata diazrenata closed this May 13, 2019
@ha0ye
Copy link
Member

ha0ye commented May 13, 2019

@diazrenata Do you want me to take a look at anything here, or should I hold off for now?

@diazrenata
Copy link
Member Author

#127 is the one to look at now! And (good timing!), I think it is to a point where it would be helpful if you get a chance to look at it. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants