-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import BBS data by route #127
Conversation
…ata directory. This speeds up build_bbs_dataset_plan
…ating prepare_bbs_ts_data twice
…tead of passing them around in memory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some general notes:
build_datasets_plan()
,build_bbs_datasets_plan()
,prepare_bbs_ts_data()
, andget_bbs_route_region_data()
all take a path argument, but the path argument isn't consistently passed between them, and so the default option is relied on.- some of the file paths are created using paste0; I think the recommend approach is to use
file.path()
so that we don't run into issues with forward-slash, back-slash confusion (across different operating systems) - one line 130, the call to
get_bbs_route_region_data()
doesn't use the path argument, and it probably needs!!
, as on lines 93 and 94. - should the default
end_yr
inprepare_bbs_ts_data()
be 2017? Maybe we can add the option to have the argument be NA, and have it be ignored?
More generally, it seems like |
Codecov Report
@@ Coverage Diff @@
## master #127 +/- ##
==========================================
- Coverage 89.18% 70.08% -19.1%
==========================================
Files 13 14 +1
Lines 490 575 +85
==========================================
- Hits 437 403 -34
- Misses 53 172 +119
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #127 +/- ##
===========================================
- Coverage 89.18% 69.72% -19.47%
===========================================
Files 13 14 +1
Lines 490 578 +88
===========================================
- Hits 437 403 -34
- Misses 53 175 +122
Continue to review full report at Codecov.
|
… argument around in build_plans
@ha0ye, could you maybe take a look at this version of things? Hopefully it's a little more streamlined! |
@diazrenata I just noticed that you have files in |
👀 Nope -apologies! I can get rid of them and fix the gitignore in a
few...
…On Tue, May 28, 2019 at 10:25 Hao Ye ***@***.***> wrote:
@diazrenata <https://github.com/diazrenata> I just noticed that you have
files in vignettes/.drake as part of your commit - did you mean to
include those?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#127?email_source=notifications&email_token=AEH6DN5ZJIPWH6EGCBH7AALPXU6HPA5CNFSM4HMRIZ4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWMJR4A#issuecomment-496539888>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEH6DNZC7YVLSAT7B6KENK3PXU6HPANCNFSM4HMRIZ4A>
.
|
- change name - remove dependency on route and region argument, check and generate this from the passed in data
save data in prepare_bbs function
pass args properly for build_bbs_datasets_plan
BBS by route patch
Functions to
datasets
plansThe initial processing step (
prepare_bbs_ts_data
) does the cleaning and subsetting necessary to get the list of routes and regions for the plans, and saves the processed abundance table and the tables for making the plans in the directory with thedata
path. The remaining functions load those data tables as needed (trying to minimize the number of times we interact with the main dataframe - it's slow to load).get_bbs_route_region_data
pulls a specified route + region and does the final cleaning on it. I've broken the cleaning into two steps because this last step takes forever and crashed R for me a few times when I tried to do it on the whole dataframe at once.build_bbs_datasets_plan
makes a drake plan to get data for all the routes. (2500 of them)build_datasets_plan
now includes the option to include BBS, in which case it will usebuild_bbs_datasets_plan
.handles #125