Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect recursion for dir=auto special cases. #10561

Merged
merged 4 commits into from
Aug 21, 2024
Merged

Fix incorrect recursion for dir=auto special cases. #10561

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
21867f8
Fix incorrect recursion for dir=auto special cases.
dbaron Aug 15, 2024
e9dd789
Also fix the exclusion clause.
dbaron Aug 15, 2024
9bbe199
Try to address first round of review comments from @annevk.
dbaron Aug 16, 2024
2049e18
Also use data-x.
dbaron Aug 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions source
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13775,8 +13775,8 @@ Transport Protocol">HTTP&lt;/abbr> today.&lt;/p></code></pre> <!-- DO NOT REWRAP
<ol>
<li><p><span>Assert</span>: <var>child</var> is an <code>Element</code> node.</p></li>

<li><p>Set <var>childDirection</var> to the <span>auto directionality</span> of
<var>child</var>.</p></li>
<li><p>Set <var>childDirection</var> to the <span>contained text auto directionality</span>
of <var>child</var> with <var>canExcludeRoot</var> set to true.</p></li>
annevk marked this conversation as resolved.
Show resolved Hide resolved
</ol>
</li>

Expand All @@ -13789,6 +13789,14 @@ Transport Protocol">HTTP&lt;/abbr> today.&lt;/p></code></pre> <!-- DO NOT REWRAP
</ol>
</li>

<li>Return the <span>contained text auto directionality</span> of <var>element</var> with
dbaron marked this conversation as resolved.
Show resolved Hide resolved
<var>canExcludeRoot</var> set to false.</li>
</ol>

<p>To compute the <dfn>contained text auto directionality</dfn> of an element
<var>element</var> with a boolean <var>canExcludeRoot</var>:</p>

<ol>
<li>
<p><span data-x="list iterate">For each</span> node <var>descendant</var> of
<var>element</var>'s <span data-x="descendant">descendants</span>, in <span>tree
Expand All @@ -13797,7 +13805,8 @@ Transport Protocol">HTTP&lt;/abbr> today.&lt;/p></code></pre> <!-- DO NOT REWRAP
<ol>
<li>
<p>If <var>descendant</var>, or any of its ancestor elements that are descendants of
<var>element</var>, is one of</p>
<var>element</var>, or (if <var>canExcludeRoot</var> is true) <var>element</var>, is one
annevk marked this conversation as resolved.
Show resolved Hide resolved
of</p>

<ul class="brief">
<li>a <code>bdi</code> element</li>
Expand Down