Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON exports #344

Merged
merged 7 commits into from
Feb 2, 2024
Merged

JSON exports #344

merged 7 commits into from
Feb 2, 2024

Conversation

chrmod
Copy link
Contributor

@chrmod chrmod commented Jan 30, 2024

For each website, do not only export the static HTML, but also dump out the data used to generate the graphs.

whotracksme/website/utils.py Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@@ -29,7 +29,7 @@
# This allows us to inject a custom version into setuptools using the
# environment variable: WTM_VERSION. If it is not specified, a default value is
# used, but you will not be able to run sdist in this case.
DEFAULT_VERSION = "dev"
DEFAULT_VERSION = "0.dev"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this need to be changed? I have not run test, but I never changed the default. I wonder if it will introduce subtle regressions?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IDK, it fails on me with just dev. from what I understand setuptools does not support dev as a valid version name

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing it from "dev" to "0.dev" did not have a noticeable effect in my setup. Thus, I'm fine with changing it.

I assume, it comes from some semantic versioning naming conventions, which require it to start with an integer. "0.devN" seems more common.

I wonder if it is also related to the README?

$ python -m pip install -e '.[dev]'

$ python -m pip install -e '.[dev]'

But the commands from the README still seem to work for me.

@philipp-classen
Copy link
Member

I would see _site/api directory as something that should be skipped using "fast-website-update".

f'{site_dir}/websites/',

@philipp-classen philipp-classen merged commit 572e020 into master Feb 2, 2024
1 check failed
@philipp-classen philipp-classen deleted the json-exports branch February 2, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants